Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Asmjit ] Asmjit update - Following pull request #39090 #39630

Merged
merged 12 commits into from
Jul 5, 2024
Merged

[Asmjit ] Asmjit update - Following pull request #39090 #39630

merged 12 commits into from
Jul 5, 2024

Conversation

JakubMelka
Copy link
Contributor

@JakubMelka JakubMelka commented Jul 1, 2024 •
edited
Loading

If this PR updates an existing port, please uncomment and fill out this checklist:

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JakubMelka
Copy link
Contributor Author

@microsoft-github-policy-service agree

@JakubMelka JakubMelka mentioned this pull request Jul 1, 2024
Closed
7 tasks
@JakubMelka
Copy link
Contributor Author

This request is following pull request #39090.

kobalicek
kobalicek reviewed Jul 1, 2024
View reviewed changes
ports/asmjit/vcpkg.json Outdated Show resolved Hide resolved
kobalicek
kobalicek reviewed Jul 1, 2024
View reviewed changes
versions/a-/asmjit.json Outdated Show resolved Hide resolved
kobalicek
kobalicek reviewed Jul 1, 2024
View reviewed changes
versions/baseline.json Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 changed the title Asmjit update - Following pull request #39090 [Asmjit ] Asmjit update - Following pull request #39090 Jul 2, 2024
JonLiu1993
JonLiu1993 reviewed Jul 2, 2024
View reviewed changes
ports/asmjit/vcpkg.json Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 marked this pull request as draft July 2, 2024 03:51
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jul 2, 2024
@JonLiu1993
Copy link
Member

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

dg0yt
dg0yt suggested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change needed. Thanks from the community.

ports/asmjit/vcpkg.json Outdated Show resolved Hide resolved
ports/fbgemm/vcpkg.json Show resolved Hide resolved
versions/f-/fbgemm.json Show resolved Hide resolved
versions/f-/fbgemm.json Outdated Show resolved Hide resolved
@JakubMelka JakubMelka marked this pull request as ready for review July 2, 2024 08:03
@JakubMelka
Copy link
Contributor Author

@JonLiu1993, I hope I have fixed all your issues.

dg0yt
dg0yt approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but someone else must approve.

@kobalicek
Copy link
Contributor

I approve, although my approval is worthless here :)

And I don't approve the patching of course, but that we know from the previous PR.

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jul 4, 2024
@JavierMatosD JavierMatosD merged commit f08f5fc into microsoft:master Jul 5, 2024
17 checks passed
@JakubMelka JakubMelka deleted the asmjit_update branch July 6, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt approved these changes

@JonLiu1993 JonLiu1993 Awaiting requested review from JonLiu1993

@kobalicek kobalicek Awaiting requested review from kobalicek

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JakubMelka @JonLiu1993 @kobalicek @dg0yt @JavierMatosD @jimwang118 @stevemk14ebr